Skip to content

installers: grub2 timeout everywhere#2505

Open
supakeen wants to merge 1 commit into
osbuild:mainfrom
supakeen:grub2-timeout
Open

installers: grub2 timeout everywhere#2505
supakeen wants to merge 1 commit into
osbuild:mainfrom
supakeen:grub2-timeout

Conversation

@supakeen

@supakeen supakeen commented Jul 10, 2026

Copy link
Copy Markdown
Member

When installer.bootloader.grub2.menu-timeout is set in the blueprint make sure it applies to all installer types. Closes #2223.

@supakeen
supakeen requested a review from a team as a code owner July 10, 2026 08:32
When `installer.bootloader.grub2.menu-timeout` is set in the blueprint
make sure it applies to *all* installer types.

Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>

@avitova avitova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I don't see this used in Grub2ISOLegacyStageOptions, do we need to add it somewhere to that structure as well? It uses the options struct which has a Grub2Config too.

// Default Grub2 menu on the ISO
DefaultMenu int
// Default Grub2 menu timeout on the ISO
MenuTimeout *int

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I have this as part of PR #2414 where I just used an int and compare with 0, the same way we do for DefaultMenu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

blueprint's grub2 timeout is not hooked up to most image types

3 participants