Generate bootc-image-builder test jobs dynamically and enable all tests#2539
Draft
achilleas-k wants to merge 7 commits into
Draft
Generate bootc-image-builder test jobs dynamically and enable all tests#2539achilleas-k wants to merge 7 commits into
achilleas-k wants to merge 7 commits into
Conversation
test_build_cross.py and test_build_iso.py were not being run. Enable them now.
Glob the test paths under bootc-image-builder/test/ to dynamically create one gitlab job for each test file. We separate these because a single job for all tests would take too long. With this change, we can be sure that no bootc-image-builder test is skipped.
We were running these two test files together since they're both relatively small and quick. Merge the two files so that our dynamic gitlab CI pipeline generator doesn't need to have any special conditions.
Enable the testcases names qemu-cross, which are used by the test_build_cross tests.
In 8a81ca5 we disabled the creation of a local registry when testing disk images. At the time we weren't testing ISOs, so there was no issue with always keeping it disabled. Now that we're testing ISOs, we need to set up the registry, but only for ISO tests. Having it enabled for all build tests, like we had before, would mean we would be setting up the registry for a lot of tests that don't need it (disk builds), which is fine when running all tests at the same time, but annoying and wasteful when testing things separately, like we do in GitLab.
Add a fixture that builds just the anaconda-iso image type. This is an alternative to the general image-type fixture, which used to handle all image builds by calling the build_images() function with the appropriate request. The separation allows us to build and test disk images without depending on the registry fixture, while having separate tests for ISOs that do. The registry fixture is only needed when testing ISOs with a signed base container.
These are still failing and need some work.
Member
Author
|
Needs work. Drafting. |
achilleas-k
marked this pull request as draft
July 22, 2026 09:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glob the test paths under bootc-image-builder/test/ to dynamically create one gitlab job for each test file. We separate these because a single job for all tests would take too long.
With this change, we can be sure that no bootc-image-builder test is skipped.
This also enables all bootc-image-builder tests.