Skip to content

fix: desktop scenes can render black — reveal clip only after a painted frame #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrobinsonai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: desktop scenes can render black — reveal clip only after a painted frame #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions skills/scroll-world/references/scrub-engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,9 @@ function mountScrollWorld(container, config) {
// Reveal the video (hide the still poster) only once a real frame has
// painted — on iOS a seeked-but-never-played muted video stays blank, so
// hiding the still on metadata alone would flash an empty scene.
v.addEventListener('seeked', () => { s.el.classList.add('has-clip'); }, { once: true });
v.addEventListener('loadeddata', () => { try { v.pause(); } catch (e) {} if (userReady) primeVideo(v); });
if (v.requestVideoFrameCallback) { v.requestVideoFrameCallback(() => { s.el.classList.add('has-clip'); }); }
else { v.addEventListener('seeked', () => { s.el.classList.add('has-clip'); }, { once: true }); }
v.addEventListener('loadeddata', () => { try { v.pause(); } catch (e) {} if (userReady || !isMobile()) primeVideo(v); });
s.el.appendChild(v); s.video = v; s.hasClip = true;
}).catch(() => { s.loading = false; });
}
Expand Down Expand Up @@ -294,7 +295,7 @@ function mountScrollWorld(container, config) {
// clips prime themselves (see loadClip).
let userReady = false;
function primeVideo(v) {
if (!isMobile() || !v) return;
if (!v) return;
try { const p = v.play(); if (p && p.then) p.then(() => { try { v.pause(); } catch (e) {} }).catch(() => {}); }
catch (e) {}
}
Expand Down