Replace deprecated ament_target_dependencies with target_link_libraries - #11
Open
mjcarroll wants to merge 1 commit into
Open
Replace deprecated ament_target_dependencies with target_link_libraries#11mjcarroll wants to merge 1 commit into
mjcarroll wants to merge 1 commit into
Conversation
The ament_target_dependencies macro has been removed in ROS 2 Lyrical. Replacing it with standard target_link_libraries. Assisted-by: Gemini CLI:2.0-Flash [run_shell_command]
marcoag
suggested changes
Sep 7, 2026
|
|
||
| add_library(fake_imu_library SHARED src/fake_imu.cpp) | ||
| ament_target_dependencies(fake_imu_library rclcpp rclcpp_components sensor_msgs example_interfaces) | ||
| target_link_libraries(fake_imu_library PUBLIC rclcpp rclcpp_components sensor_msgs example_interfaces) |
Member
There was a problem hiding this comment.
The above couldn't find rclcpp on Jazzy, it seems we need the namespaced form for clean builds:
Suggested change
| target_link_libraries(fake_imu_library PUBLIC rclcpp rclcpp_components sensor_msgs example_interfaces) | |
| target_link_libraries(fake_imu_library PUBLIC rclcpp::rclcpp rclcpp_components::component ${sensor_msgs_TARGETS} ${example_interfaces_TARGETS}) |
|
|
||
| add_library(imu_sink_library SHARED src/imu_sink.cpp) | ||
| ament_target_dependencies(imu_sink_library rclcpp rclcpp_components sensor_msgs example_interfaces) | ||
| target_link_libraries(imu_sink_library PUBLIC rclcpp rclcpp_components sensor_msgs example_interfaces) |
Member
There was a problem hiding this comment.
Suggested change
| target_link_libraries(imu_sink_library PUBLIC rclcpp rclcpp_components sensor_msgs example_interfaces) | |
| target_link_libraries(imu_sink_library PUBLIC rclcpp::rclcpp rclcpp_components::component ${sensor_msgs_TARGETS} ${example_interfaces_TARGETS}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the deprecated (and removed in Lyrical)
ament_target_dependenciesmacro with standardtarget_link_libraries.Verified on Ubuntu Resolute (26.04) as part of the Lyrical unblocking effort.
Assisted-by: Gemini CLI:2.0-Flash [run_shell_command]