Make examples work with ament_nodl 2.0. - #13
Open
marcoag wants to merge 1 commit into
Open
Conversation
Signed-off-by: Marco A. Gutierrez <marcogg@marcogg.com>
wjwwood
approved these changes
Sep 8, 2026
Comment on lines
-24
to
-26
| # TODO(wjwwood): go back to organizing these into a nodl folder when this is fixed: | ||
| # https://github.com/ubuntu-robotics/nodl/issues/41 | ||
| # nodl_export_node_description_file(nodl/fake_imu.nodl.xml) |
Member
Author
|
Me hoping to merge and github be like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ament_nodl2.0 (released Sep 4, ros/rosdistro#53761) removed thenodl_export_node_description_file()CMake macro and dropped support for XML NoDL documents, which breaksros2launch_security_examplesat configure time on every buildfarm that received the new release (i.e. Jazzy). This change replaces the two macro calls withament_nodl_register(), and the.nodl.xmlfiles are converted to schema v2 YAML documents preserving the same interface.Also the documents now live in a nodl/ subdirectory, resolving the long-standing TODO(wjwwood) that was blocked on ros-tooling/nodl#41.