Fix boolean field variants in combined item infoboxes#212
Draft
Copilot wants to merge 3 commits into
Draft
Conversation
Co-authored-by: allenkinzalow <2922507+allenkinzalow@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix alchable info box output for combined item page
Fix alchable field variants in combined item infoboxes
Feb 2, 2026
allenkinzalow
requested changes
Feb 4, 2026
allenkinzalow
left a comment
Contributor
There was a problem hiding this comment.
@copilot While this does fix the issue for alchable, it does not fix the issue where one item variant has a field as true and the other has undefined and it not treating those two values as field1=true, field2=false.
…ined Co-authored-by: allenkinzalow <2922507+allenkinzalow@users.noreply.github.com>
Contributor
Author
Fixed in commit 3f89cef. Changed both |
Copilot
AI
changed the title
Fix alchable field variants in combined item infoboxes
Fix boolean field variants in combined item infoboxes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Combined item pages with differing boolean field values were incorrectly using shared parameters instead of variants. This was a general issue affecting any boolean field where one variant had a defined value and another had
undefined.Examples:
|alchable = Noinstead of|alchable1 = Yesand|alchable2 = No|placeholder = Yesinstead of|placeholder1 = Noand|placeholder2 = YesRoot cause:
InfoboxItemwas setting boolean fields toundefinedwhen they should be explicit boolean values.InfoboxTemplate.buildMultipleParams()filters out undefined values before comparison, causing it to incorrectly use shared parameters when values differ.Changes
alchablefield (line 37): now returnstrueinstead ofundefinedfor alchable items (whenNO_ALCHABLE_PARAMis not set)placeholderfield (line 30): now returnsfalseinstead ofundefinedfor non-placeholder items (whenplaceholderLinkedItem <= 1)Result
Now correctly outputs:
|alchable = Yes|alchable = No|alchable1 = Yesand|alchable2 = No✅|placeholder1 = Noand|placeholder2 = Yes✅Checklist
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.