drop GCS-specific integration test scaffolding#709
Open
mzihlmann wants to merge 1 commit into
Open
Conversation
mzihlmann
force-pushed
the
drop-gcs-integration-scaffolding
branch
from
d0c0837 to
828956e
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
mzihlmann
force-pushed
the
drop-gcs-integration-scaffolding
branch
from
708f8fe to
8ff0f73
Compare
mzihlmann
force-pushed
the
drop-gcs-integration-scaffolding
branch
from
8ff0f73 to
f91dae5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCP integration tests aren't exercised in this fork — there's no GCP project, service account, or test bucket wired into CI — so the GCS-specific test scaffolding has been dead code for a while: tarball uploads to GCS,
-b gs://...build contexts, service-account credential mounting, and thegcloud builds submitbenchmark path. This removes all of it.Production GCS support is untouched. The
gs://source-context fetcher inpkg/buildcontext/gcs.go, the bucket helpers it relies on, and the vendoredcloud.google.com/go/storagechain all stay, since real users build fromgs://contexts.Dockerfile_test_copy_bucketnow runs as a plain context test. Vendor size is unchanged because the storage dependency is still reachable from production code; the win is test-suite clarity.