fix(ci): stamp baseline target version and draft flag at publish time - #550
Merged
eddie-knight merged 5 commits intoAug 31, 2026
Merged
Conversation
Published artifacts for v2026.08.28 shipped with their osps-baseline mapping-reference still reading 'draft' and metadata.draft still true, because only metadata.version was stamped at publish time. The committed YAML is correct as-is (in-repo it tracks devel), so extend the existing publish-time stamp instead of editing the documents each release: - pin each mapping document's osps-baseline reference to RELEASE_VERSION - set metadata.draft from ARTIFACT_DRAFT: false for explicitly versioned publishes (release tag or dispatch version input), true for the dev-SHA fallback; only applied where a draft flag already exists All 15 stamped artifacts verified against the CUE schema locally. Signed-off-by: Eddie Knight <knight@linux.com>
A drifted osps-baseline reference id would make the version pin a silent
no-op, and `cue vet` would still pass because "draft" is a valid version
string — the same failure class that shipped v2026.08.28 unstamped. Assert
the pin took effect on each staged mapping document before grcli publishes
it; the catalog has no osps-baseline self-reference and is exempt.
Also drop the `with(select(has("draft")))` guard: all 15 artifacts carry
metadata.draft, so it only served to let a future artifact that forgot the
flag ship without one instead of getting the correct value.
Verified locally by running the publish loop verbatim with grcli stubbed:
both trigger paths stamp all 15 artifacts and pass `cue vet`, and renaming
the reference id aborts the loop before any mapping is published.
Signed-off-by: Eddie Knight <knight@linux.com>
eddie-knight
marked this pull request as draft
August 31, 2026 12:29
Signed-off-by: Eddie Knight <knight@linux.com>
Signed-off-by: Eddie Knight <knight@linux.com>
eddie-knight
force-pushed
the
fix/published-artifact-metadata
branch
from
August 31, 2026 13:06
247e241 to
c5cac8a
Compare
eddie-knight
marked this pull request as ready for review
August 31, 2026 13:08
Signed-off-by: Eddie Knight <21176439+eddie-knight@users.noreply.github.com>
funnelfiasco
approved these changes
Aug 31, 2026
david-a-wheeler
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Published artifacts for v2026.08.28 shipped with their osps-baseline mapping-reference still reading 'draft' and metadata.draft still true, because only metadata.version was stamped at publish time. The committed YAML is correct as-is (in-repo it tracks devel), so extend the existing publish-time stamp instead of editing the documents each release:
All 15 stamped artifacts verified against the CUE schema locally.