fix(routes): remove unreachable MAX_ADDRESS_LENGTH check (#117) - #145
Open
ZacLou wants to merge 1 commit into
Open
fix(routes): remove unreachable MAX_ADDRESS_LENGTH check (#117)#145ZacLou wants to merge 1 commit into
ZacLou wants to merge 1 commit into
Conversation
isValidStellarAddress already accepts only well-formed 56-character G... keys, so the subsequent length check can never fire. It also would block 69-character muxed M... addresses once the validator is widened, so remove the dead code now. Closes ourdao#117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
Removes the unreachable
MAX_ADDRESS_LENGTHcheck in the challenge route:isValidStellarAddressalready rejects anything that is not a well-formed 56-characterG…key, so the later length check can never fire.M…addresses once the validator is widened, so removing it avoids a future foot-gun.Verified with:
npm run typechecknpm run lint(only pre-existing warnings)