fix(ipfs): forward permissions through uploadMultipleDocuments - #195
Open
ZacLou wants to merge 1 commit into
Open
fix(ipfs): forward permissions through uploadMultipleDocuments#195ZacLou wants to merge 1 commit into
ZacLou wants to merge 1 commit into
Conversation
…o#181) uploadMultipleDocuments ignored its callers' permissions intent and silently defaulted every batch-uploaded document to { public: !encrypted }. - Add an optional permissions argument to uploadMultipleDocuments. - Pass it through to createDocumentMetadata for each file. - Update DocumentUpload.tsx to pass permissions directly instead of remapping metadata after upload. - Add a test asserting permissions are applied to every item. Closes ourdao#181
|
Someone is attempting to deploy a commit to the Meshack Yaro's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @bbjiggy, the Vercel deployment check is failing with 'Authorization Required' for team 'Meshack Yaro'''s projects'. As an external contributor I don't have permission to authorize Vercel for this team. Could you please click the authorize link in the failing check? The code change itself is ready for review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #181
uploadMultipleDocuments ignored its callers permissions intent and silently defaulted every batch-uploaded document to { public: !encrypted }. This adds an optional permissions argument and passes it through to createDocumentMetadata for each file, and updates DocumentUpload.tsx to pass permissions directly instead of remapping metadata after upload.