Update for latest hyprland commit#261
Conversation
|
patch works |
|
:3 |
|
ik there's not error messages for the dispatch api but I was doing this at like 2am lol. I can try and figure out what appropriate errors would be when I get off work and finish some apprenticeship work tonight if that is needed. |
|
hyprland got another update, LMAO latest version built hy3 successfully is a5b7c91329313503e8864761f24ef43fb630f35c |
Bruhhh, I'll see what I can do when I get back from college today lol. |
|
Type shi. I got it building again and seems to work okay so far? I'm ngl I do not have much experience with c++ at all so I am just reading the errors and trying my damndest to make em go away by fixing them. I rebooted into the latest hyprland with this commit of hy3 just now and so far no crash! xD |
Where I get stuck I ask if Claude has any ideas. If they look sane enough I try them and fingies crossed lmao. |
It's building correctly. ps |
Yippeee! :> |
|
@outfoxxed , please, accept that mr |
|
after latest update fail Logger was moved to a new place |
|
@Immelancholy |
|
check the mr Immelancholy#1 |
Imma be on it dw, I've been at work all day. |
outfoxxed
left a comment
There was a problem hiding this comment.
This doesn't compile on the updated nix pin either
/home/admin/programming/outfoxxed/hyprland/hy3/src/dispatchers.cpp:6:10: fatal error: hyprland/src/debug/log/Logger.hpp: No such file or directory
6 | #include <hyprland/src/debug/log/Logger.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/hy3.dir/build.make:93: CMakeFiles/hy3.dir/src/dispatchers.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /home/admin/programming/outfoxxed/hyprland/hy3/src/globals.hpp:10,
from /home/admin/programming/outfoxxed/hyprland/hy3/src/main.cpp:8:
/home/admin/programming/outfoxxed/hyprland/hy3/src/log.hpp:3:10: fatal error: hyprland/src/debug/log/Logger.hpp: No such file or directory
3 | #include <hyprland/src/debug/log/Logger.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/hy3.dir/build.make:79: CMakeFiles/hy3.dir/src/main.cpp.o] Error 1
In file included from /home/admin/programming/outfoxxed/hyprland/hy3/src/globals.hpp:10,
from /home/admin/programming/outfoxxed/hyprland/hy3/src/Hy3Node.cpp:15:
/home/admin/programming/outfoxxed/hyprland/hy3/src/log.hpp:3:10: fatal error: hyprland/src/debug/log/Logger.hpp: No such file or directory
3 | #include <hyprland/src/debug/log/Logger.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from /home/admin/programming/outfoxxed/hyprland/hy3/src/globals.hpp:10,
from /home/admin/programming/outfoxxed/hyprland/hy3/src/Hy3Layout.cpp:26:
/home/admin/programming/outfoxxed/hyprland/hy3/src/log.hpp:3:10: fatal error: hyprland/src/debug/log/Logger.hpp: No such file or directory
3 | #include <hyprland/src/debug/log/Logger.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/hy3.dir/build.make:121: CMakeFiles/hy3.dir/src/Hy3Node.cpp.o] Error 1
make[2]: *** [CMakeFiles/hy3.dir/build.make:107: CMakeFiles/hy3.dir/src/Hy3Layout.cpp.o] Error 1
In file included from /home/admin/programming/outfoxxed/hyprland/hy3/src/globals.hpp:10,
from /home/admin/programming/outfoxxed/hyprland/hy3/src/TabGroup.cpp:24:
/home/admin/programming/outfoxxed/hyprland/hy3/src/log.hpp:3:10: fatal error: hyprland/src/debug/log/Logger.hpp: No such file or directory
3 | #include <hyprland/src/debug/log/Logger.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/hy3.dir/build.make:135: CMakeFiles/hy3.dir/src/TabGroup.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:87: CMakeFiles/hy3.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
0ac8e07 to
609b4c9
Compare
|
Latest commit from that branch is not building with latest hyprland. |
- Changed dispatcher functions to return `SDispatchResult`.
- Updated all `HyprlandAPI::addDispatcher` calls to `HyprlandAPI::addDispatcherV2`.
- Added missing `return SDispatchResult {};` statements to dispatcher functions.
- Introduced `static` keyword for all dispatcher functions.
0c4f6da to
30f1b5e
Compare


Adds the dispatcherV2 code from #168 as there were build errors preventing it from building in #256 and should fix #260 by updating m_reservedTopLeft and m_reservedBottomRight to use m_reservedArea