fix(tabs): refresh tab highlight on monitor focus change#298
Open
sim590 wants to merge 1 commit into
Open
Conversation
sim590
force-pushed
the
fix/focusmonitor-tab-highlight
branch
from
April 28, 2026 02:20
e874aa7 to
a6b7ef5
Compare
Author
|
Update: Also include special workspaces (scratchpad) in the tab bar refresh loop. Previously, tabs inside a special workspace were not updated on monitor focus change because the listener only iterated over |
… moniteur Desktop::focusState()->monitor() n'est pas encore mis à jour au moment où les barres d'onglets sont recalculées lors d'un changement de moniteur. On suit maintenant le moniteur focalisé via un état interne (g_focusedMonitor) mis à jour par l'événement monitor.focused, et on rafraîchit les barres d'onglets de tous les moniteurs à ce moment.
sim590
force-pushed
the
fix/focusmonitor-tab-highlight
branch
from
May 27, 2026 18:33
a6b7ef5 to
0a3544e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
focusmonitororhy3:movefocus monitor:movefocusRoot cause
Desktop::focusState()->monitor()is not yet updated when tab bars are recalculated during a monitor focus change. This causedactive_monitorto be computed against the stale (previous) monitor value, producing inverted highlight behavior.Fix
g_focusedMonitor, updated from themonitor.focusedeventg_focusedMonitorinstead ofDesktop::focusState()->monitor()inupdateNodeList()to computeactive_monitorupdateDecos()on all monitors when the focused monitor changes, so both the old and new monitor tab bars refresh correctly