fix(movetoworkspace): guard node dereference when moving floating window#304
Open
sim590 wants to merge 1 commit into
Open
fix(movetoworkspace): guard node dereference when moving floating window#304sim590 wants to merge 1 commit into
sim590 wants to merge 1 commit into
Conversation
When a floating window (not managed by hy3) is moved to another workspace with follow=true, getWorkspaceFocusedNode returns nullptr. The code correctly takes the floating window path and calls moveWindowToWorkspaceSafe, but then falls through to the follow block which calls node->layout() unconditionally, causing a SIGSEGV. Add a null check before dereferencing node in the follow block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a floating window (not managed by hy3) is focused and
hy3:movetoworkspaceis dispatched withfollow=true,getWorkspaceFocusedNodereturnsnullptrbecause the window has no hy3 node. The code correctly takes the floating-window path and callsmoveWindowToWorkspaceSafe, but then falls through to theif (follow)block which callsnode->layout()unconditionally, causing a SIGSEGV.Reproducible with any floating window (e.g. alacritty in float mode):
Fix
Add a null check on
nodebefore dereferencing it in the follow block. The workspace switch and monitor focus still happen; only the hy3-specific recalc and focus calls are skipped when there is no hy3 node to act on.