fix: tab bars rendered in wrong orientation on rotated monitors#317
fix: tab bars rendered in wrong orientation on rotated monitors#317yeldiRium wants to merge 1 commit into
Conversation
projectBoxToTarget internally composes getScaleMatrix() with targetProjection.projectBox(), where targetProjection (m_projMatrix) already contains the monitor's WL transform rotation. Passing monitor_inverted as the transform parameter applies the inverse rotation inside projectBox(), cancelling out the rotation already present in m_projMatrix — reproducing the double-rotation bug that was originally fixed in 0525702. Pass HYPRUTILS_TRANSFORM_NORMAL instead, leaving m_projMatrix's rotation intact, which is equivalent to the pre-refactor fix of rdata.projection * monitorProjection.projectBox(monitorBox, NORMAL). Assisted-by: Copilot <223556219+Copilot@users.noreply.github.com>
51c66bf to
72b401b
Compare
|
FYI I am also running into this issue. I have two external monitors, one is rotated 270 degrees, and the tab bar is completely borked on the rotated monitor.
Edit: I stand corrected, the fix works just fine (I was loading the wrong .so this whole time). Thanks for your patch @yeldiRium |
|
can confirm that on nixos 26.05 (which, relative to 25.11, introduced this as a regression), you can do the following in home-manager: and the bug goes away. patch lgtm (for whatever some random outsider's opinion is worth) |
|
Also confirming this patch solves the issue. (NixOS 26.05) |
hi,
since development on #314 seems stalled, i wanted to give it a try. I have very little experience with cpp but otherwise a lot of development experience and used github copilot to make the fix. Of course i tested the changes locally, since i don't want to submit slop anywhere, and the issue is fixed on my computer with a 90° rotated monitor.
Since the issue existed before (#182) i assumed that some later change reintroduced it. Copilot found the regression introduced in 76010d9 and the fix looks reasonable and simple to me. here is copilots explanation of the change:
I hope this makes sense and the change is reasonable and i'm not wasting anyone's time.
Fixes #314.