Karam.alburaim/t2#324
Merged
Merged
Conversation
Fix header guard to ensure proper compilation.
Add missing newline at the end of square.h
ov-ale
reviewed
May 25, 2026
ov-ale
left a comment
ov-ale
left a comment
Owner
There was a problem hiding this comment.
- Код ожидает поля строго в порядке key1, key2, key3. В задании порядок может быть любым
- Проблема с чтением ULL литерала (нет проверки суффикса как строки)
- Проблема с компаратором (сравнение double через !=)
- while (std::cin) проверяет состояние до чтения, что может привести к лишней итерации и добавлению пустой записи
- Проблема с CharGuard. Отсутствует std::istream::sentry, что может привести к неожиданному поведению при ошибках потока
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.