Move native extension inside module

[wyattanderson]

The goal here is to address this issue with delocate, so that we can internally distribute relocatable binary wheels for OS X:

matthew-brett/delocate#12 (comment)

I've tested a little bit locally, but would love assistance testing more substantially. I'm not very familiar with Python packaging when it comes to native extensions.

[ovalhub]

Looking for the _icu extension, with or without your change, I see it in two locations: ./lib/python3.6/site-packages/PyICU-2.4-py3.6-macosx-10.12-x86_64.egg/_icu.cpython-36m-darwin.so ./lib/python3.6/site-packages/PyICU-2.4-py3.6-macosx-10.12-x86_64.egg/icu/_icu.cpython-36m-darwin.so Thus, I don't understand the effect of your change, nor why I'm seeing this. But I didn't try to debug this much yet. Andi..

…

On Fri, 18 Oct 2019, Wyatt Anderson wrote: The goal here is to address this issue with `delocate`, so that we can internally distribute relocatable binary wheels for OS X: matthew-brett/delocate#12 (comment) I've tested a little bit locally, but would love assistance testing more substantially. I'm not very familiar with Python packaging when it comes to native extensions. You can view, comment on, or merge this pull request online at: #113 -- Commit Summary -- * Move native extension inside module -- File Changes -- M _icu.cpp (4) M icu/__init__.py (2) M setup.py (2) -- Patch Links -- https://github.com/ovalhub/pyicu/pull/113.patch https://github.com/ovalhub/pyicu/pull/113.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #113

[wyattanderson]

Sorry for the confusion here; I rushed this out without enough of a description.

The problem I'm running into is when building and installing a wheel, not an egg: the _icu.so file ends up installed in the root of site-packages alongside the icu/ directory, which prevents delocate from modifying it. The motivation for this change is to ensure that when a PyICU wheel is installed, that the _icu.so file is installed inside the icu/ directory instead. Does that make sense? I can try and clarify further if necessary.