fix(utils): unblock PR lanes on main's story gate defects - #1342
Closed
schickling-assistant wants to merge 3 commits into
Closed
schickling-assistant wants to merge 3 commits into
schickling-assistant wants to merge 3 commits into
Conversation
oxlint's exported-JSDoc rule flags storyGateReporterOutput (introduced in #1333); the push run on main skips the lint lane, so every pull request lane inherited the failure. agent-identity: dev3.direct.omp.t3mkm4sd agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.1.14 agent-runtime: OMP 18.1.14 tooling-profile: dotfiles@5d1e05f
schickling-assistant
added
area:typescript
agent-identity: dev3.direct.omp.t3mkm4sd agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.1.14 agent-runtime: OMP 18.1.14 tooling-profile: dotfiles@5d1e05f
The fake vitest fixture used '#!/usr/bin/env node'; the Buck test environment has no node on PATH, so the fixture exited 127 before the completion reporter published and both completion-protocol tests failed (merged red in #1333, #1336, #1337). Use process.execPath, which is the runtime executing the test. agent-identity: dev3.direct.omp.t3mkm4sd agent-persona: generalist agent-supervisor: unavailable agent-tool: OMP agent-tool-version: 18.1.14 agent-runtime: OMP 18.1.14 tooling-profile: dotfiles@5d1e05f
schickling-assistant
changed the title
Collaborator
Author
schickling-assistant
deleted the
schickling-assistant/2026-09-22-story-gate-jsdoc
branch
September 22, 2026 20:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two main defects from the story-gate PRs (#1333, #1336, #1337 were merged with red lint/test lanes; the push-to-main workflow does not run those lanes) fail every open PR:
packages/@overeng/utils/src/node/storybook/gate/completion-reporter.ts:37: Missing JSDoc comment for exported 'const storyGateReporterOutput'(run 35761492261, job 106860361221).effect_utils//packages/@overeng/utils:test:run.unit.test.ts > runVitest completion protocol× 2 — the fakevitestfixture is written with#!/usr/bin/env node; the Buck test environment has nonodeonPATH, so it exits 127 before the completion reporter publishes (run 35769289903, job 106886621243).Goal
PR lint and test lanes green on main's content again.
Decisions
#!${process.execPath}: the runtime executing the test is the one the fixture must run under; no dependency onPATH.Verification
DEVENV_TASK_PASSTHROUGH=1 oxfmt --checkandoxlinton both files: clean.vitest run src/node/storybook/gate/run.unit.test.tsinpackages/@overeng/utils(devenv shell): 38 passed.Complexity
No new complexity.
Concerns
Three PRs merged with failing required lanes; whatever merged them bypassed the gate. Worth checking the branch protection / auto-merge path.
Follow-ups
References