This repository was archived by the owner on Apr 30, 2026. It is now read-only.
enable log ingestion from csv, json, jsonl#25
Merged
Conversation
pritamsoni-hsr
changed the title
akhatre
reviewed
Feb 4, 2026
| if log_item.trace_state: | ||
| ctx["trace_state"] = log_item.trace_state | ||
|
|
||
| context = None |
Contributor
There was a problem hiding this comment.
so if spans are added without context - would these IDs get auto-generated by otel? if not we should auto-generate some uuids for them
Contributor
Author
There was a problem hiding this comment.
yes these ids will be autogenerated
we could add validation for ids tho, it accept 16/32 chars and not uuid, but i just didn't bother
akhatre
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.