Fix illegal memory access caused by missing _kernel_block_sizes attribute in some vLLM versions#330
Open
lianghao208 wants to merge 1 commit into
Open
Fix illegal memory access caused by missing _kernel_block_sizes attribute in some vLLM versions#330lianghao208 wants to merge 1 commit into
lianghao208 wants to merge 1 commit into
Conversation
…ot defined in some vLLM versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In vLLM 0.16, gpu_model_runner does not have the
self._kernel_block_sizesattribute. As a result, kernel_block_sizes = getattr(self, "_kernel_block_sizes", None) returns None, which causes kvcached to incorrectly assume ratio = 1. This leads to an excessively large stride value being computed, ultimately resulting in an illegal memory access error.For example:
This PR adds proper handling for the case where _kernel_block_sizes is not defined, ensuring the stride is computed correctly across different vLLM versions.