Skip to content

chore(deps-dev): bump gulp-strip-css-comments from 1.2.0 to 3.0.0 - #1322

Open
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/gulp-strip-css-comments-3.0.0
Open

chore(deps-dev): bump gulp-strip-css-comments from 1.2.0 to 3.0.0#1322
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/gulp-strip-css-comments-3.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 1, 2023

Copy link
Copy Markdown
Contributor

Bumps gulp-strip-css-comments from 1.2.0 to 3.0.0.

Release notes

Sourced from gulp-strip-css-comments's releases.

v3.0.0

Breaking

  • Require Node.js 18 cba3950
  • This package is now pure ESM. Please read this.

sindresorhus/gulp-strip-css-comments@v2.0.0...v3.0.0

Commits

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@sonarqubecloud

sonarqubecloud Bot commented Nov 1, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dj4oC dj4oC left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Security: no findings
  • Stability: no CI checks recorded at all for this head commit (0 check runs) — this PR is from Nov 2023 and predates the repo's current GitHub Actions setup, so it's never actually been validated by CI.
  • Performance: n/a
  • Test coverage: n/a
  • TODOs found: 0
  • Dependency touched: yes — gulp-strip-css-comments (dev-only)
  • CI status: none reported (stale/pre-dates current CI)

Verdict

Recommend closing — this PR is over 2 years stale, was never exercised by the current CI pipeline, and Dependabot will re-open a fresh PR against current master if the dependency is still outdated. Not approving as-is.

🤖 Automated review by Claude Code (security · stability · performance · coverage)


Generated by Claude Code

@DeepDiver1975

Copy link
Copy Markdown
Contributor

@dependabot rebase

Bumps [gulp-strip-css-comments](https://github.com/sindresorhus/gulp-strip-css-comments) from 1.2.0 to 3.0.0.
- [Release notes](https://github.com/sindresorhus/gulp-strip-css-comments/releases)
- [Commits](sindresorhus/gulp-strip-css-comments@v1.2.0...v3.0.0)

---
updated-dependencies:
- dependency-name: gulp-strip-css-comments
  dependency-version: 3.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title Bump gulp-strip-css-comments from 1.2.0 to 3.0.0 chore(deps-dev): bump gulp-strip-css-comments from 1.2.0 to 3.0.0 Jul 13, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/gulp-strip-css-comments-3.0.0 branch from c5c253c to bc6d751 Compare July 13, 2026 11:00
@dependabot
dependabot Bot requested a review from a team as a code owner July 13, 2026 11:00
@DeepDiver1975

Copy link
Copy Markdown
Contributor

Holding: CI is failing (not a rebase conflict). Failing check(s): build / Build. A rebase won't fix this — needs a human/upstream fix.

@DeepDiver1975

Copy link
Copy Markdown
Contributor

Holding: CI is failing (not a rebase conflict) — root-cause refinement, supersedes my earlier comment on this PR (which only named the failing check). The run log (29244751018) is past retention (HTTP 410), so this was re-derived structurally from the head-of-branch manifests plus the npm registry.

gulp-strip-css-comments 3.0.0 is ESM-only: the registry metadata shows "type": "module" and engines.node >= 18 for 3.0.0, versus commonjs for 1.2.0. It also swapped gulp-util for gulp-plugin-extras and strip-css-comments ^3 -> ^5.

gulpfile.js loads it with a CommonJS require():

stripCSS = require('gulp-strip-css-comments'),

so under 3.0.0 that throws ERR_REQUIRE_ESM while the gulpfile is still being evaluated — which is why build / Build fails outright rather than failing inside a task.

Note this is an ESM-only break, not a gulp-peer break: it is independent of this repo also still being on gulp ^3.9.1. Fixing it needs either an ESM-aware gulpfile (dynamic import()) or staying on the 2.x line. A rebase will not fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants