chore(deps-dev): bump gulp from 3.9.1 to 5.0.1 - #1349
Conversation
…s deps (#1361) The karma test suite runs on Firefox (tests/js/config/karma.js, gulpfile.js); `karma-phantomjs-launcher` and `phantomjs-prebuilt` were unreferenced anywhere except package.json. `phantomjs-prebuilt` was the SOLE path pulling in the vulnerable request -> tough-cookie / uuid chain. Removing both dead dev deps eliminates those transitive packages entirely. Fixed (packages removed from the dependency tree): - request 2.88.2 removed (#58, SSRF, GHSA-p8p7-x288-28g6; deprecated, no fix) - tough-cookie 2.5.0 removed (#64, prototype pollution, needs >= 4.1.3) - uuid 3.4.0 removed (#129, buffer bounds check, needs >= 11.1.1) Verified: `yarn install --frozen-lockfile` clean, `yarn build` (gulp) green. Test suite runs on Firefox inside an ownCloud core checkout (CI: xvfb) and is unaffected — the removed packages play no role in the karma runtime. Not fixable here (no upstream fix / would need a major migration): - angular / angular-sanitize (#43,#46,#59,#60,#61,#73,#84,#85,#90,#91) — AngularJS 1.x is EOL; all first_patched are null. Real remediation is a framework migration off AngularJS. - babel-traverse 6.26.0 (#76, critical) — only @babel/traverse 7.x is patched; needs babel 6 -> 7 toolchain migration. - lodash.template 3.6.2 (#77, high) — pulled by gulp-util/gulp 3.x; no patched line, deprecated. Resolved by the pending gulp 3 -> 5 upgrade (#1349). Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
dj4oC
left a comment
There was a problem hiding this comment.
- Security: no findings (gulp 3.9.1 → 5.0.1, build-tooling devDependency)
- Stability: CI red on
Commits / Validate semantic commitsandbuild / Build;JS Unit/PHP jobs pass. gulp 3→5 is a major bump of the build tool itself — worth confirming the build actually still runs after this, sincebuild/Buildis failing. - Performance: no findings
- Test coverage: n/a (dependency bump)
- TODOs found: 0
- Dependency touched: yes — gulp (MIT), major bump
- CI status: failing (Commits, build)
Verdict
Not mergeable as-is — build check is red. Not approving until CI is green.
🤖 Automated review by Claude Code (security · stability · performance · coverage)
Generated by Claude Code
|
@dependabot rebase |
9ead1bc to
0d41358
Compare
|
Holding: CI is failing (not a rebase conflict). Failing check(s): build / Build. A rebase won't fix this — needs a human/upstream fix. |
|
@dependabot rebase |
Bumps [gulp](https://github.com/gulpjs/gulp) from 3.9.1 to 5.0.1. - [Release notes](https://github.com/gulpjs/gulp/releases) - [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md) - [Commits](gulpjs/gulp@v3.9.1...v5.0.1) --- updated-dependencies: - dependency-name: gulp dependency-version: 5.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
0d41358 to
3f8d0b1
Compare
|
Holding: CI is failing (not a rebase conflict) — root-cause refinement, supersedes my earlier comment on this PR (which only named the failing check). Run 29815077608 is past log retention (HTTP 410), so this was re-derived structurally from This repo is still genuinely on the gulp 3 API ( gulp.task('lint', ['jslint']); // line 84
gulp.task('default', ['lint', '_buildSource', '_buildVendor']); // line 85
gulp.task('build', ['lint', '_buildSource']); // line 86
gulp.task('_buildSource', ['_buildAndMinifyCSSSources', ...]); // line 94
gulp.task('_buildVendor', ['_buildAndMinifyCSSVendor', ...]); // line 95
gulp.watch(watchSources, ['_buildSource']); // line 217gulp 4 dropped This is a gulpfile migration, not a version pin: all the composite tasks above have to be rewritten as |
Bumps gulp from 3.9.1 to 5.0.1.
Release notes
Sourced from gulp's releases.
... (truncated)
Changelog
Sourced from gulp's changelog.
... (truncated)
Commits
0003e9fchore: release 5.0.1 (#2837)19122f3fix: Avoid globbing before read stream is opened (#2839)69a5d0efix: Avoid Node.js deprecation warning forfs.Stats(#2838)04b4a74fix: Support top-level await on Node 22.12+ (#2836)c90e79echore: Fix CI (#2835)5412605chore(docs): Update async completion document for newer RxJS (#2831)2fa4981chore: Update glob docs with replacement to ordered globs (#2788)fe9dee6chore: Remove locale docs (#2787)a85eddbchore: Remove node-glob options from docs (#2786)9c818e6chore: update src.md docs to add encoding parameter