Simplify getserver2serverproperties method#799
Open
settermjd wants to merge 5 commits intoowncloud:masterfrom
Open
Simplify getserver2serverproperties method#799settermjd wants to merge 5 commits intoowncloud:masterfrom
settermjd wants to merge 5 commits intoowncloud:masterfrom
Conversation
While reviewing this method as part of a software audit, I noticed a couple of areas where the method could, potentially, be streamlined, and improved. This commit adds the initial set of tests which make those improvements possible.
$server2ServerSharing doesn't need to be instantiated, as the comparison natively returns true or false. As a result, returning the result of the comparison can be done when initialising the returned array.
While there's nothing wrong with how it's currently done, I feel that it's overly verbose, and can be simplified, as in this commit. By doing so, it should make it that much easier to read and maintain.
Potentially not necessary, but having the function arguments listed underneath each other seemed to be that much easier to read. Perhaps it's just me, but it seems worth doing.
Author
|
@patrickjahns, would you mind reviewing this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: No specific issue number. The commit seemed worthwhile, as I was reviewing the code.
Licence: MIT or AGPL
Description
This PR simplifies (and adds tests to)
PageController::getServer2ServerProperties(). I noticed that it could be streamlined while conducting a code audit.Features
n/a
Screenshots or screencasts
n/a
Caveats
n/a
Tests
Added tests for:
Tested on
TODO
Check list
Reviewers
@patrickjahns