Skip to content

feat(ocis): enable OTLP and antivirus tracing - #960

Open
amamus wants to merge 1 commit into
owncloud:mainfrom
amamus:codex/ocis-alignment-issue-16
Open

feat(ocis): enable OTLP and antivirus tracing#960
amamus wants to merge 1 commit into
owncloud:mainfrom
amamus:codex/ocis-alignment-issue-16

Conversation

@amamus

@amamus amamus commented Sep 3, 2026

Copy link
Copy Markdown

Description

  • allow otlp as a supported global tracing provider while retaining the Jaeger default
  • document the provider-specific endpoint and collector behavior, including the OTLP gRPC port
  • activate the four supported ANTIVIRUS_TRACING_* environment variables
  • exercise the source-aligned OTLP configuration in the chart's comprehensive CI values profile

Changed files:

  • charts/ocis/values.yaml
  • charts/ocis/values.schema.json
  • charts/ocis/templates/antivirus/deployment.yaml
  • charts/ocis/ci/lint-values.yaml
  • charts/ocis/docs/values.adoc.yaml
  • charts/ocis/docs/values-desc-table.adoc

Related Issue

  • oCIS-to-Helm alignment backlog: ISSUE 16

Motivation and Context

The chart schema accepted only Jaeger even though the current oCIS reference deployment uses OTLP, causing source-aligned values to fail Helm schema validation. The chart also retained a stale comment saying Antivirus tracing was not implemented, so Antivirus did not receive the shared tracing configuration.

The alignment source of truth is deployments/examples/ocis_full. Its tracing environment selects otlp and the gRPC endpoint jaeger:4317. The current Antivirus tracing configuration supports the enabled, type, endpoint, and collector variables for both global and service-specific prefixes.

Jaeger remains the backward-compatible chart default. tracing.collector is documented as the Jaeger HTTP fallback because the oCIS OTLP provider consumes only tracing.endpoint.

This PR is based directly on the current owncloud/ocis-charts default branch and has no dependency on an earlier alignment PR. Scanner and ClamAV deployment changes remain reserved for ISSUE 17.

How Has This Been Tested?

  • test environment: Helm 3.16.2, Helmfile 0.169.1, kube-linter 0.6.8, and kubeconform 0.6.7 on macOS arm64
  • verified the generated schema accepts jaeger and otlp and rejects an unsupported zipkin value
  • parsed focused renders to verify the Antivirus deployment receives each tracing variable exactly once with both legacy Jaeger defaults and otlp/jaeger:4317
  • verified the exhaustive render has 33 traced Deployments and 132 tracing environment variables with consistent OTLP values
  • verified disabling virus scanning omits the Antivirus workload
  • make docs GOBIN=/private/tmp/ocis-issue10-tools (schema and documentation generation is idempotent)
  • make lint-ci GOBIN=/private/tmp/ocis-issue10-tools
  • make lint-examples GOBIN=/private/tmp/ocis-issue10-tools (all ten examples)
  • make api GOBIN=/private/tmp/ocis-issue10-tools (Kubernetes 1.28, 1.29, 1.30, and 1.31; 177/177 resources valid for each version)
  • packaged the chart successfully and inspected its generated values
  • git diff --check

Screenshots (if appropriate):

Not applicable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added (not applicable; the configuration is covered by schema, parsed render, and lint-profile validation)
  • Acceptance tests added (not applicable)
  • Documentation generated (make docs) and committed
  • Documentation ticket raised (not applicable)
  • Documentation PR created (not applicable)

Signed-off-by: David Walter <d@amamus.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant