feat(ocis): enable OTLP and antivirus tracing - #960
Open
amamus wants to merge 1 commit into
Open
Conversation
Signed-off-by: David Walter <d@amamus.net>
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
otlpas a supported global tracing provider while retaining the Jaeger defaultANTIVIRUS_TRACING_*environment variablesChanged files:
charts/ocis/values.yamlcharts/ocis/values.schema.jsoncharts/ocis/templates/antivirus/deployment.yamlcharts/ocis/ci/lint-values.yamlcharts/ocis/docs/values.adoc.yamlcharts/ocis/docs/values-desc-table.adocRelated Issue
Motivation and Context
The chart schema accepted only Jaeger even though the current oCIS reference deployment uses OTLP, causing source-aligned values to fail Helm schema validation. The chart also retained a stale comment saying Antivirus tracing was not implemented, so Antivirus did not receive the shared tracing configuration.
The alignment source of truth is
deployments/examples/ocis_full. Its tracing environment selectsotlpand the gRPC endpointjaeger:4317. The current Antivirus tracing configuration supports the enabled, type, endpoint, and collector variables for both global and service-specific prefixes.Jaeger remains the backward-compatible chart default.
tracing.collectoris documented as the Jaeger HTTP fallback because the oCIS OTLP provider consumes onlytracing.endpoint.This PR is based directly on the current
owncloud/ocis-chartsdefault branch and has no dependency on an earlier alignment PR. Scanner and ClamAV deployment changes remain reserved for ISSUE 17.How Has This Been Tested?
jaegerandotlpand rejects an unsupportedzipkinvalueotlp/jaeger:4317make docs GOBIN=/private/tmp/ocis-issue10-tools(schema and documentation generation is idempotent)make lint-ci GOBIN=/private/tmp/ocis-issue10-toolsmake lint-examples GOBIN=/private/tmp/ocis-issue10-tools(all ten examples)make api GOBIN=/private/tmp/ocis-issue10-tools(Kubernetes 1.28, 1.29, 1.30, and 1.31; 177/177 resources valid for each version)git diff --checkScreenshots (if appropriate):
Not applicable.
Types of changes
Checklist:
make docs) and committed