Fix empty web.yaml config causing Missing or invalid config error - #968
Open
amamus wants to merge 2 commits into
Open
Fix empty web.yaml config causing Missing or invalid config error#968amamus wants to merge 2 commits into
amamus wants to merge 2 commits into
Conversation
The NATS service was failing to start JetStream with: Can't start JetStream: could not create storage directory - mkdir /var/lib/ocis/nats: permission denied This happened because the init container only chown'd /var/lib/ocis, but NATS JetStream needs to create a 'nats' subdirectory. The non-root NATS container could not create this directory. This fix adds a second init container that explicitly creates /var/lib/ocis/nats and sets the correct ownership before the main NATS container starts. Fixes owncloud#887 Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
The web configmap was generating an empty config section when no styles, scripts, customTranslations, or apps were configured, resulting in: This caused the web service to fail with 'Missing or invalid config'. This fix conditionally includes the config section only when at least one of the sub-values (styles, scripts, customTranslations, apps) is set. Fixes owncloud#918 Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web configmap was generating an empty config section when no styles,
scripts, customTranslations, or apps were configured, resulting in:
web:
config:
This caused the web service to fail with 'Missing or invalid config'.
This fix conditionally includes the config section only when at least one
of the sub-values (styles, scripts, customTranslations, apps) is set.
Fixes #918
Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe vibe@mistral.ai