fix: allow ownCloud 11 patch releases - #229
Open
oc-tmueller wants to merge 1 commit into
Open
Conversation
max-version was pinned to the exact patch release 11.0.0, so `occ app:enable testing` refuses to enable the app on any 11.0.x above it: App "QA testing" cannot be installed because the following dependencies are not fulfilled: ownCloud 11.0.0 or lower is required. Core CI clones this app and enables it in the Install Server step of every acceptance job, so bumping core's version.php to 11.0.1 turned every API and CLI acceptance suite red before a single test ran. The app is also shipped in the -qa release bundles, so the same failure would hit a QA tarball install. Pin the major version instead, which is what all 43 apps bundled in the ownCloud 11 release specs already do (`max-version="11"`). min-version stays at 10.0 — the app still supports the oc10 line. Refs: owncloud/core#41825 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line:
max-version="11.0.0"→max-version="11".What breaks today
max-versionis pinned to the exact patch release11.0.0, soocc app:enable testingrefuses the app on any higher 11.0.x:Core CI clones this app and enables it in the Install Server step of every acceptance job, before any test runs. So bumping core's
version.phpto 11.0.1 (owncloud/core#41825, preparing the 11.0.1 release) turns all eight API and CLI acceptance checks red for a reason unrelated to the change under test:app:enable files_sharing…federatedfilesharingapp:enable testingownCloud 11.0.0 or lower is requiredThis app is also shipped in the
-qarelease bundles (apps/testingin the complete-qa spec), so the same failure would hit anyone installing a QA tarball of 11.0.1.Why the major version
All 43 apps bundled in the ownCloud 11 release specs already use
max-version="11". I checked every one of them while tracking this down —testingis the only app pinning a patch version, and the only one that would block an 11.0.x release.min-versionstays at10.0; the app still supports the oc10 line.How this was found
Core#41825 bumps
version.phpto 11.0.1 and adds a changelog fragment — two files, nothing functional. Its acceptance suites went red. The merge base was master's HEAD, whose own CI was green, and re-running the failed jobs reproduced it identically, so it was not flaky. The failing step turned out to beInstall Server, and the cause was this dependency check rather than anything in that PR.No release of this app is needed: core CI clones it from
master, so merging this is enough to unblock core#41825.🤖 Generated with Claude Code