Quote/splice formatting fixes for attributes & comments#137
Merged
jbachurski merged 5 commits intojanefrom Apr 23, 2026
Merged
Conversation
jbachurski
force-pushed
the
jbachurski/further-quote-splice-fixes
branch
from
11aef01 to
8786254
Compare
jbachurski
force-pushed
the
jbachurski/further-quote-splice-fixes
branch
from
8786254 to
9032c83
Compare
also use the standard parenze method for determining whether to parenthesize and fix the double-parenthisization bug more broadly Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
even though they are syntactically redundant, their absence is often visually confusing, and this pr is not the place to find a general fix Signed-off-by: David Vulakh <dvulakh@janestreet.com>
dvulakh
approved these changes
Apr 22, 2026
jbachurski
commented
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$((int list[@attr])).I briefly parenthesised splices of atomic expressions with pre-fix/post-fix comments (e.g.
$((* pre *) int)/$(int (* post *))), but this is actually inconsistent with prefix operators, which should probably format the same as splices in these cases. I added a test showing that.