MRIB: Multicast RIB implementation #576
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
zl/mrib
branch
from
5e30869 to
60d37bc
Compare
zeeshanlakhani
force-pushed
the
zl/mrib
branch
3 times, most recently
from
71919aa to
512b04d
Compare
Implements the Multicast Routing Information Base for multicast
support. The MRIB follows a two-table architecture (mrib_in → mrib_loc)
with RPF verification against the unicast RIB when sources are provided.
This PR includes:
- `rdb/src/db.rs`: modifications to accomodate MRIB implementation and
persistence
- `rdb/src/mrib/mod.rs`: the core MRIB implementation with route storage and
change notifications
- `rdb/src/mrib/rpf.rs`: RPF verification using poptrie for O(1) LPM lookups,
with rate-limited rebuilds triggered on unicast RIB changes
- `rdb/src/types.rs`: Validated multicast address types with input validation
- `mg-api/src/lib.rs`: API v3 (VERSION_MULTICAST_SUPPORT) with new endpoints
- `mgd/src/mrib_admin.rs`: HTTP handlers bridging API to MRIB
- `mgadm/src/mrib.rs`: CLI for MRIB inspection and configuration
Note that Omicron is source of truth multicast overlay/underlay
groups/addresses.
zeeshanlakhani
force-pushed
the
zl/mrib
branch
from
512b04d to
327a609
Compare
zeeshanlakhani
requested review from
FelixMcFelix,
rcgoodfellow and
taspelund
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
taspelund
reviewed
Dec 9, 2025
Contributor
|
Things are looking good overall. So far, I've been able to review everything except for |
taspelund
reviewed
Dec 9, 2025
MRIB: API naming consistency and doc and validation fixes Address PR #576 review feedback: rename MRIB functions to match unicast patterns (get_mrib_*, read/update_mrib_*), fix stale doc comments, make API more flexible, and minor cleanups.
Author
|
Note: test-interop is expected to fail currently until @taspelund's upcoming work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Multicast Routing Information Base (MRIB) for multicast support. The MRIB follows a two-table architecture (
mrib_in→mrib_loc) with RPF verification against the unicast RIB when sources are provided.This PR includes:
rdb/src/db.rs: modifications to accomodate MRIB implementation and persistencerdb/src/mrib/mod.rs: the core MRIB implementation with route storage and change notificationsrdb/src/mrib/rpf.rs: RPF verification using poptrie for O(1) LPM lookups, with rate-limited rebuilds triggered on unicast RIB changesrdb/src/types.rs: Validated multicast address types with input validationmg-api/src/lib.rs: API v4 (VERSION_MULTICAST_SUPPORT) with new endpointsmgd/src/mrib_admin.rs: HTTP handlers bridging API to MRIBmgadm/src/mrib.rs: CLI for MRIB inspection and configurationNote that Omicron is source of truth multicast overlay/underlay groups/addresses.