Repository navigation
test: drop assertions that cannot fail - #416
Conversation
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
commit: |
|
auto-merge: no head out of
|
4deeef7 to
4d8361c
Compare
Current-base gate — not merged
Required CI observed at this head
Context and acceptanceFull diff inspected for routing: this removes existing assertions and an entire CLI verification test file, rather than adding isolated tests. The CI-only exception does not apply to changed assertions. No independent test run or final correctness signoff on the removed guarantees is claimed. Stopped at the current-base gate; not merged. No further code review or independent verification is run against a behind candidate. No branch update, conflict resolution, fix-and-merge or protection bypass was performed. Revisit only after the author supplies a current-base-containing, conflict-free candidate with all required checks present, executed and successful; then restart at CI, review and independent acceptance. Unchanged blockers need no duplicate processing. |
|
auto-merge: no head out of
Policy from #345 head |
4d8361c to
3e03c44
Compare
分支更新结果按开发者授权，使用 GitHub 原生分支更新（rebase）将 PR 更新到当前 base。
未手动修改文件或解决冲突，未进行代码审查、验收或合并。旧版本 CI 和验收结论不能用于新 head；等待新版本必需 CI 全部成功且无冲突、不落后后，再进入审查。 |
|
更新后的 base 复核：通过 GitHub commit compare 确认新 head |
|
auto-merge: no head out of
exclusions.md not the primary hit (no product control-flow change), but fail-closed on weakened verification still blocks auto-merge. |
3e03c44 to
416f6e9
Compare
|
分支跟进当前 base：旧 head |
CI 门禁失败：未进入审查
当前 required checks：Check、react-doctor、另一项 preview SUCCESS；这一项 Publish @getpie/cli preview 失败。GitHub job 记录显示依赖安装及 CLI 构建通过，失败步骤是 Publish preview to pkg.pr.new。 这不是对实现质量的结论。必需 CI 尚未全成功，停止于 CI 门禁；没有查看产品 diff、运行独立功能验证、修复或合并，也没有重跑检查或绕过保护。 重新处理条件：明确处理发布检查失败，随后对包含当前 main、无冲突的新候选重新检查全部 required CI。原因若是外部服务/网络，需要记录诊断与有依据的后续处理；不可仅反复重跑直到变绿。 |
|
补充上一条 CI 阻塞记录：失败日志明确出现 pkg.pr.new 的 HTTP 500，随后 |
|
发布故障已具备一次受控重试的依据：原失败是 pkg.pr.new HTTP 500/Headers Timeout；随后 #402 的同一 preview workflow（run 36738144611）中实际 不改代码、不削弱检查；若再次失败就保留阻塞继续诊断，不循环刷绿。新结果全部成功后才进入代码审查与独立验收。 |
CI 恢复后审查发现：必须保留隔离保护的负例Head 完整 diff 与调用链审查发现：删除 当前不予通过、不合并。按开发者已授权的无新决策修复范围，后续修复将保留原有负例并补 help/version 正例；修复版本必须重新通过 CI，再交独立审查和验收，不把本次修复视作自我批准。 |
修复提交与独立审查交接
保留 这是实现者的修复自检记录，不是独立验收或批准。已普通推送并触发新 CI；不复用旧 head 的全绿状态。下一步：新 required CI 全部成功后，由独立审查者在干净 worktree 审查完整 PR 并验收。UI 产品路径仍需 Web/Desktop 截图与视频（适用时）。本轮没有合并。 |
独立审查后的覆盖修复独立审查在 head 已在新 head 实现者实际运行 4 个相关测试文件：32 项通过，无类型错误；格式、diff、提交钩子通过。未改产品代码，普通推送触发新 CI。 前次独立审查结论仍是阻塞，不能由本条自检替代。新的完整 PR 必须重新通过 CI 与独立复核后才能合并；未合并。 |
|
auto-merge: no head out of
Din review-first: no squash-merge. |
Remove pure self-comparisons, a help-flag probe that passes if the predicate is always false, and cases already owned at a stronger boundary.
a71c5e1 to
92b025b
Compare
|
After #415 and #417 passed independent acceptance and merged, GitHub-native rebase updated this PR from |
|
auto-merge: no head out of
fail closed; no merge / no update-branch. |
Independent acceptance — blocked, not mergedHead Fresh pinned reviewer worktree, locked dependencies and Turbo builds. Independent results:
Not accepted or merged. These failures have not been attributed to this test-only diff or established as baseline failures. No source fix, conflict resolution, protection bypass or deferred merge. A diagnosed/repaired E2E path with successful independent acceptance is required before proceeding; do not merely rerun until green. Local raw logs/daemon records are not uploaded because they may contain runtime credentials. |
|
auto-merge: no head out of
fail closed — comment only (Din review-first; no merge). |
Queue update after verified #423 merge — waiting at CIHead Required CI for this new head is queued/in progress at this observation, so no old-head review or acceptance is carried forward. The earlier failed Desktop acceptance remains unresolved; a main sync is not evidence that it passed. No merge or deferred auto-merge. Continue only after the applicable blocker is resolved and the new version passes required CI → review → independent acceptance. |
|
auto-merge: no head Out of the allowed groups (docs/tooling, lint-format, ui-presentation):
|
审查与验证记录：通过
审查 逐项检查了被删除的断言，确认每项要保护的性质仍由其他测试覆盖：
非阻塞：PR 描述仍写着"删除 独立验证 在 reviewer 自己的干净 worktree 中检出 本 PR 只改测试，没有运行时界面，所以不需要 UI 证据。 结论：通过，可以合并。如果 head 或 base 发生变化，从 CI 重新开始。 |
|
已合并（squash）。merge commit 为 |
2 participants
Summary
f(x) === f(x)) in session keys, SSH state keys, socket dirs, cron jitter, andstableHash. They cannot fail while those functions stay pure.isHelpOrVersionnegatives. They pass if the predicate always returns false, and they never check--help.pie/branch-name echo. Session and CLI tests already require^pie/[0-9a-f]{8}$.Kept security, protocol, path, package, and visual-class contracts. Those still have no stronger owner.
Proof