Repository navigation
Conversation
commit: |
|
React Doctor skipped this pull request — it changed no React files. Reviewed by React Doctor for commit |
Current-base gate — not merged
Required CI observed at this head
Additional blockerRequired Stopped at the current-base gate; not merged. No further code review or independent verification is run against a behind candidate. No branch update, conflict resolution, fix-and-merge or protection bypass was performed. Revisit only after the author supplies a current-base-containing, conflict-free candidate with all required checks present, executed and successful; then restart at CI, review and independent acceptance. Unchanged blockers need no duplicate processing. |
CI 失败定位与修复方向
这是对既有阻塞新增的日志定位，不是代码审查通过。未本地重现或验证修复方案，未修改分支、重跑 CI 或合并。修复/环境恢复并得到满足当前 base 的全绿候选后，重新从 CI → 审查 → 独立验收开始。 |
修复提交与独立审查交接
在真实 Chromium 中复现原失败：4 项测试中 2 项抛 这是实现者的修复自检记录，不是独立验收或批准。已普通推送并触发新 CI；不复用旧 head 的全绿状态。下一步：新 required CI 全部成功后，由独立审查者在干净 worktree 审查完整 PR 并验收。UI 产品路径仍需 Web/Desktop 截图与视频（适用时）。本轮没有合并。 |
7ff74fb to
cb72270
Compare
|
GitHub-native rebase updated the repaired candidate from |
Independent review — blocked by a narrow-pane regressionReviewed head P2 — collapsed macOS titlebar clearance clips narrow list controls.
Expected: collapse the Desktop sidebar and resize either split list to its minimum; traffic-light clearance must remain while every header/filter control remains visible and usable, with normal search/list width. This is a source-derived finding independently cross-checked by the coordinator, not a claimed live reproduction. The reviewer’s Chromium geometry probe was blocked before execution by sandbox socket restrictions. A repair needs an executed narrow-layout regression and later actual Desktop/Web acceptance. Other conclusions: the missing SidebarProvider repair matches production ownership; session titlebar extraction preserves its previous conditions. No new privilege, authorization, persistence or untrusted-data security defect was identified. PR wording claiming expanded Web is entirely unchanged conflicts with the unconditional Schedule Actual independent checks: app typecheck passed; 27 focused node tests passed. Browser tests were not executed successfully (socket The coordinator will handle the straightforward layout correction in an implementation role. After a new head, restart at successful CI, independent review, and real Web/Desktop proof. A fix comment will not resolve this review by itself. |
|
auto-merge: no head out of
fail closed; no merge / no update-branch. |
Queue update after verified #423 merge — waiting at CIHead Required CI for this new head is queued/in progress at this observation, so no old-head review or acceptance is carried forward. The earlier narrow-window title-bar/layout finding is not resolved by this base sync. No merge or deferred auto-merge. Continue only after the applicable blocker is resolved and the new version passes required CI → review → independent acceptance. |
|
auto-merge: no head Out of the allowed groups; hits exclusions:
|
Those pages already paint their own top row. On desktop the empty shell drag strip sat above it, and Scheduled added pt-8 on top of that. The page row is the drag strip now.
Traffic lights only cover the top band. Applying that inset to a 16rem schedule list or an 18rem pull-request list clipped the filters and squeezed search. Push those controls below the band instead.
618534c to
2e818db
Compare
|
Narrow-pane repair is on this branch, rebased onto current main. Traffic lights only cover the top band. The 132px inset is no longer applied to the schedule list or the pull-request filter row. Those controls sit below the band, so an 18rem list keeps every label and a normal search width. Desktop proof, sidebar collapsed, pull-request list dragged to its 18rem minimum:
Expanded web has no desktop inset. Scheduled / Pull requests / Plugins headers sit at the card top. Removing Scheduled
recording-001.webmrecording-001.webm |
Blocked: required Check fails on head
|
The session panel renders PullRequestInspect without SidebarProvider. The drag region belongs to the full-page route, not that shared view.
The navigation rail owns the desktop traffic-light row, so the card no longer needs a second drag strip. Keep that shell header and drop the old titlebar inset that would have left a blank band under the rail.
|
Merged current Resolved the shell conflicts by keeping the rail layout:
Layout/route browser tests passed: |
|
auto-merge: no head This head has no net diff against main: GitHub compare Not merging an empty change. I'd suggest closing this PR as superseded by #435, unless a follow-up change is still planned for this branch. |
|
Closing as superseded by #435 (merged as 3e27258). Compare |
2 participants
Summary
pt-8above its title on any host. Expanded web never had the shell strip; this padding change is the web-visible part.Verification
pnpm exec turbo run typecheck --filter=@getpie/appAuthoredis clipped by the inset; after, All / Reviewing / Authored stay fully visible and search is not inset.