Conversation
Owner
Author
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
commit: |
Owner
Author
|
auto-merge: no head: Fail closed on exclusions + no matching allowed group:
Din review-first; no merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Requirement
Skill search was a case-insensitive substring over name, description, and the full source path. It did not rank hits and did not mark the matched letters.
agent browsermissedagent-browser, and a path fragment such aspimatched every skill under~/.pi.Expected behavior
The Skills page and the
/menu rank skills by name match, then description.-,_,/, and spaces are equivalent. The winning field bolds matched letters and dims the rest. Commands stay above skills and keep their existing prefix rank. An empty query keeps the original order.Changes and risks
Shared matcher in
apps/app/src/lib/skill-search.ts, used by the Skills panel and slash-command filter. No stored data or contract change. Queryskillno longer returns every skill through a keyword, and the source path is no longer searched.Verification
2975fd39:pnpm --filter @getpie/app exec vitest run src/lib/skill-search.test.ts src/features/chat/components/input/slash-command-suggestions.test.ts— 2 files, 7 passed.pnpm exec turbo run typecheck --filter=@getpie/app— passed on the pre-move tree. The move only changed import paths and replaced a fragment with a span.pie-verify webrun20261001T060848Z-26966: Plugins → Skills, searchskill creatormarksskillandcreatorand leaves the hyphen unmatched. Draft/skilluses the same marks.slash-command-menu.test.tsxwas not run.