Repository navigation
docs: close gaps found in parallel PR review - #434
Merged
Merged
Conversation
Record the constraints that failed in practice: pinned worktrees, exact CI identity, owned cleanup, and real Pi configuration.
commit: |
Launch now rejects the isolation mistake that hid the operator's Pi configuration. Rules only point at that check.
The CI poll waited for transitions that were still running on a slow runner. Finish them after the dialog opens so geometry checks see the settled state.
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Owner
Author
Merge recordSquash-merged at the Developer's explicit request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirement
Parallel PR review and verification hit failures the current rules still allow or contradict. Record those outcomes so the next pass does not repeat them.
Expected behavior
main. Each candidate has its own worktree. A merge invalidates other candidates' bases.PI_CODING_AGENT_DIRor guess-restore shared settings.Changes and risks
Rules only. No product, persistence, or verify-helper change. The seeded E2E
PI_CODING_AGENT_DIRoverride stays limited to that fake provider.Verification
Diff review against the failures below. No runtime surface is affected.
PIE_PORTsent two launches at 4180. Occupied ports must fail, not attach.currentand could stop the other run. Explicit cleanup now has to target that run and refuse foreign or corrupt targets before stopping anything.agent-browserand ambient env could bind the wrong surface. A shim refusal stopped the drive; it is not permission to kill the other run.PI_CODING_AGENT_DIRwas treated as isolation and hid real model config. The toolchain rule now limits that override to seeded E2E.ghmetadata went stale or disagreed with REST. Required preview checks share a name; one SUCCESS is not enough.main.