Repository navigation
chore: stop passing --no-extensions to the Pi child - #443
Conversation
commit: |
审查阻塞:领域文档与行为不一致(head
|
Pie-owned children load built-in, global, and Project extensions. The daemon model list still does not.
|
审查意见已处理,未合并。 已在
核对过代码:
#427 和 #438 仍 open,且与 |
Review and verification record — approved and merged
Review
Independent verificationClean worktree at this head, locked install, Turbo build of server + CLI.
|
|
Merged as c020c97 (squash, head guard |
Requirement
Pie should not start Pi with
--no-extensions. Developer request.Expected behavior
pie-pi-process, live Sessions andget_commandsdiscovery) start with--approveonly.Changes and risks
project-resource-policy.ts:PI_PROJECT_PROCESS_ARGSis now["--approve"].agent.test.ts: the fake Pi now rejects--no-extensionsinstead of requiring it.pie-pi-process(rpc/main.ts) never readparsed.noExtensions. It always loadsbuiltInExtensionsand discovered extensions, so the flag had no effect.get_commandsreturns the same commands, including extension commands such asmcpandfff-*, with and without the flag.e2e) still answered prompts.PI_PROJECT_LOADER_OPTIONS.noExtensionsforlistAvailablePiModels. That runs Pi's SDK inside the daemon, so enabling it would execute extension code in the Pie server process. A consequence is that models registered only by extensions do not appear in the model list. Changing that is a separate decision.Verification
Tested revision:
6b06ef71.get_commandsgives identical output with--approve --no-extensionsand with--approve, using an isolatedPI_CODING_AGENT_DIRthat has an extension provider and an MCP config.pnpm buildandpnpm checkpass. Server tests: 638 passed, 1 skipped.