Skip to content

fix(infra): use dns name for docker deploy host - #832

Open
marzipan99 wants to merge 1 commit into
masterfrom
codex/fix-docker-tls-hostname
Open

fix(infra): use dns name for docker deploy host#832
marzipan99 wants to merge 1 commit into
masterfrom
codex/fix-docker-tls-hostname

Conversation

@marzipan99

Copy link
Copy Markdown
Contributor

Summary

  • connect the Docker provider through oyasai.io instead of the current public IP literal
  • avoid TLS SAN mismatches when the public IP changes, since the server certificate already includes DNS:oyasai.io

Tests

  • /nix/var/nix/profiles/default/bin/nix fmt
  • git diff --check
  • /nix/var/nix/profiles/default/bin/nix flake check -L failed while building existing Node dependency readdirp before CDKTF completed
  • /nix/var/nix/profiles/default/bin/nix build .#oyasai-cdktf -L --no-link failed while building existing Node dependency universalify before oyasai-cdktf completed

Notes

  • This touches a CODEOWNERS-owned CDKTF file and should require @shunueda approval.

@marzipan99
marzipan99 requested a review from shunueda as a code owner August 4, 2026 00:53
@marzipan99

Copy link
Copy Markdown
Contributor Author

@shunueda 良かれと思ってグローバル IPからoyasai.io に変えたけど、TLS証明を毎回修正する方がいい?


new DockerProvider(this, id, {
host: `tcp://${platformInfra.ipv4}:2376`,
host: "tcp://oyasai.io:2376",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
host: "tcp://oyasai.io:2376",
host: `tcp://${platformInfra.rootDnsRecord.name}:2376`,

@shunueda

shunueda commented Aug 4, 2026

Copy link
Copy Markdown
Member

@shunueda 良かれと思ってグローバル IPからoyasai.io に変えたけど、TLS証明を毎回修正する方がいい?

Discordで話した通り、とりあえず現状維持でいけるか試して、いけたらこれに変更も検討しよう

@shunueda

shunueda commented Aug 4, 2026

Copy link
Copy Markdown
Member

おそらくオンプレだとこっちの方がいい。長期的に移行を検討

@shunueda
shunueda force-pushed the master branch 6 times, most recently from 5236cc5 to 0dfee3b Compare August 9, 2026 23:43
@shunueda
shunueda force-pushed the master branch 2 times, most recently from 3f6f8de to 965e1d8 Compare August 19, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants