fix(infra): use dns name for docker deploy host - #832
Open
marzipan99 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@shunueda 良かれと思ってグローバル IPからoyasai.io に変えたけど、TLS証明を毎回修正する方がいい? |
shunueda
requested changes
Aug 4, 2026
|
|
||
| new DockerProvider(this, id, { | ||
| host: `tcp://${platformInfra.ipv4}:2376`, | ||
| host: "tcp://oyasai.io:2376", |
Member
There was a problem hiding this comment.
Suggested change
| host: "tcp://oyasai.io:2376", | |
| host: `tcp://${platformInfra.rootDnsRecord.name}:2376`, |
Member
Discordで話した通り、とりあえず現状維持でいけるか試して、いけたらこれに変更も検討しよう |
Member
|
おそらくオンプレだとこっちの方がいい。長期的に移行を検討 |
shunueda
force-pushed
the
master
branch
6 times, most recently
from
August 9, 2026 23:43
5236cc5 to
0dfee3b
Compare
shunueda
force-pushed
the
master
branch
2 times, most recently
from
August 19, 2026 01:57
3f6f8de to
965e1d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oyasai.ioinstead of the current public IP literalDNS:oyasai.ioTests
/nix/var/nix/profiles/default/bin/nix fmtgit diff --check/nix/var/nix/profiles/default/bin/nix flake check -Lfailed while building existing Node dependencyreaddirpbefore CDKTF completed/nix/var/nix/profiles/default/bin/nix build .#oyasai-cdktf -L --no-linkfailed while building existing Node dependencyuniversalifybeforeoyasai-cdktfcompletedNotes