Skip to content

fix: release active fraction after sealing on startup and shutdown - #477

Open
eguguchkin wants to merge 1 commit into
mainfrom
0-release-active-after-sealing
Open

fix: release active fraction after sealing on startup and shutdown#477
eguguchkin wants to merge 1 commit into
mainfrom
0-release-active-after-sealing

Conversation

@eguguchkin

@eguguchkin eguguchkin commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

This is a minor fix that removes leftover files after sealing, both on startup and on shutdown. Currently, WAL files may remain undeleted after sealing. This isn't critical though, since they get cleaned up automatically when the store restarts.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.95%. Comparing base (e1ed059) to head (0585e79).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   70.97%   70.95%   -0.02%     
==========================================
  Files         232      232              
  Lines       18293    18295       +2     
==========================================
- Hits        12984    12982       -2     
- Misses       4336     4339       +3     
- Partials      973      974       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
AggDeep/size=1000-4 e1ed05 32fc85
5152.00 ns/op 6494.00 ns/op 1.26 🔴
AggDeep/size=10000-4 e1ed05 32fc85
51317.00 ns/op 63045.00 ns/op 1.23 🔴
AggDeep/size=1000000-4 e1ed05 32fc85
5230924.00 ns/op 6515544.00 ns/op 1.25 🔴
AggWide/size=1000-4 e1ed05 32fc85
5168.00 ns/op 6486.00 ns/op 1.26 🔴
AggWide/size=10000-4 e1ed05 32fc85
50505.00 ns/op 66775.00 ns/op 1.32 🔴
AggWide/size=1000000-4 e1ed05 32fc85
529.00 B/op 695.00 B/op 1.31 🔴
5671609.00 ns/op 7172092.00 ns/op 1.26 🔴
And/size=1000-4 e1ed05 32fc85
5.05 ns/op 6.26 ns/op 1.24 🔴
And/size=10000-4 e1ed05 32fc85
5.05 ns/op 6.28 ns/op 1.24 🔴
And/size=1000000-4 e1ed05 32fc85
4.52 ns/op 5.77 ns/op 1.28 🔴
AndTree/size=1000-4 e1ed05 32fc85
4.41 ns/op 5.61 ns/op 1.27 🔴
AndTree/size=10000-4 e1ed05 32fc85
4.41 ns/op 5.70 ns/op 1.29 🔴
AndTree/size=1000000-4 e1ed05 32fc85
4.81 ns/op 6.03 ns/op 1.25 🔴
Bitmask-4 e1ed05 32fc85
223724052.00 ns/op 290126816.00 ns/op 1.30 🔴
Block_Pack-4 e1ed05 32fc85
109010.00 ns/op 144014.00 ns/op 1.32 🔴
Block_Unpack-4 e1ed05 32fc85
92335.00 ns/op 126668.00 ns/op 1.37 🔴
BucketClean-4 e1ed05 32fc85
45283.00 ns/op 56506.00 ns/op 1.25 🔴
Complex/size=1000-4 e1ed05 32fc85
5.05 ns/op 6.24 ns/op 1.24 🔴
Complex/size=10000-4 e1ed05 32fc85
5.05 ns/op 6.15 ns/op 1.22 🔴
Complex/size=1000000-4 e1ed05 32fc85
5.54 ns/op 7.28 ns/op 1.31 🔴
ESBulk-4 e1ed05 32fc85
4767.63 MB/s 3923.88 MB/s 0.82 🔴
67615.00 ns/op 82062.00 ns/op 1.21 🔴
FindSequence_Random/extra-large-4 e1ed05 32fc85
9692.29 MB/s 8590.30 MB/s 0.89 🔴
108262.00 ns/op 122065.00 ns/op 1.13 🔴
FindSequence_Random/large-4 e1ed05 32fc85
15730.57 MB/s 13525.07 MB/s 0.86 🔴
1042.00 ns/op 1211.00 ns/op 1.16 🔴
FindSequence_Random/medium-4 e1ed05 32fc85
9811.02 MB/s 8134.53 MB/s 0.83 🔴
104.60 ns/op 125.90 ns/op 1.20 🔴
FindSequence_Random/small-4 e1ed05 32fc85
6282.24 MB/s 5232.38 MB/s 0.83 🔴
40.80 ns/op 48.93 ns/op 1.20 🔴
FindSequence_Random/tiny-4 e1ed05 32fc85
2537.71 MB/s 1942.00 MB/s 0.77 🔴
25.22 ns/op 32.96 ns/op 1.31 🔴
Indexer-4 e1ed05 32fc85
271028262.00 ns/op 312290820.00 ns/op 1.15 🔴
MergeQPRs_ReusingQPR-4 e1ed05 32fc85
3722025.00 ns/op 4436275.00 ns/op 1.19 🔴
MergeSource-4 e1ed05 32fc85
1649170920.00 ns/op 2031333041.00 ns/op 1.23 🔴
MutexListAppend-4 e1ed05 32fc85
184.95 MB/s 166.97 MB/s 0.90 🔴
NAnd/size=1000-4 e1ed05 32fc85
4.68 ns/op 5.76 ns/op 1.23 🔴
NAnd/size=10000-4 e1ed05 32fc85
4.70 ns/op 5.80 ns/op 1.24 🔴
NAnd/size=1000000-4 e1ed05 32fc85
4.79 ns/op 6.14 ns/op 1.28 🔴
Not/size=1000-4 e1ed05 32fc85
5.03 ns/op 6.67 ns/op 1.33 🔴
Not/size=10000-4 e1ed05 32fc85
5.04 ns/op 6.40 ns/op 1.27 🔴
Not/size=1000000-4 e1ed05 32fc85
5.21 ns/op 7.06 ns/op 1.35 🔴
NotEmpty/size=1000-4 e1ed05 32fc85
5.05 ns/op 6.18 ns/op 1.22 🔴
NotEmpty/size=10000-4 e1ed05 32fc85
5.05 ns/op 6.18 ns/op 1.22 🔴
NotEmpty/size=1000000-4 e1ed05 32fc85
5.04 ns/op 6.57 ns/op 1.30 🔴
Or/size=1000-4 e1ed05 32fc85
4.64 ns/op 5.91 ns/op 1.27 🔴
Or/size=10000-4 e1ed05 32fc85
4.67 ns/op 5.83 ns/op 1.25 🔴
Or/size=1000000-4 e1ed05 32fc85
4.71 ns/op 5.81 ns/op 1.23 🔴
OrTree/size=1000-4 e1ed05 32fc85
4.69 ns/op 6.08 ns/op 1.30 🔴
OrTree/size=10000-4 e1ed05 32fc85
4.68 ns/op 5.82 ns/op 1.24 🔴
OrTree/size=1000000-4 e1ed05 32fc85
5.45 ns/op 7.25 ns/op 1.33 🔴
OrTreeNextGeq/size=1000-4 e1ed05 32fc85
4.68 ns/op 5.92 ns/op 1.26 🔴
OrTreeNextGeq/size=10000-4 e1ed05 32fc85
4.68 ns/op 5.58 ns/op 1.19 🔴
OrTreeNextGeq/size=1000000-4 e1ed05 32fc85
5.26 ns/op 6.72 ns/op 1.28 🔴
ParseESTime/es_stdlib-4 e1ed05 32fc85
198.70 ns/op 258.10 ns/op 1.30 🔴
ParseESTime/handwritten-4 e1ed05 32fc85
44.03 ns/op 54.66 ns/op 1.24 🔴
ParseESTime/rfc3339-4 e1ed05 32fc85
57.38 ns/op 70.68 ns/op 1.23 🔴
ProcessDocuments-4 e1ed05 32fc85
13324.00 B/op 16233.00 B/op 1.22 🔴
92.83 MB/s 75.59 MB/s 0.81 🔴
4444012.00 ns/op 5450114.00 ns/op 1.23 🔴
Sealing_NoSort-4 e1ed05 32fc85
1194959516.00 ns/op 1475503447.00 ns/op 1.23 🔴
Sealing_WithSort-4 e1ed05 32fc85
2294962601.00 ns/op 2893513469.00 ns/op 1.26 🔴
SeqListAppend-4 e1ed05 32fc85
116.04 MB/s 100.71 MB/s 0.87 🔴
137913962.00 ns/op 158878232.00 ns/op 1.15 🔴
SeqQLParsing-4 e1ed05 32fc85
1266.00 ns/op 1653.00 ns/op 1.31 🔴
SeqQLParsingLong-4 e1ed05 32fc85
10973.00 ns/op 13701.00 ns/op 1.25 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants