allow boolean switch with '--enable-foo=true/false'#318
Open
rtgiskard wants to merge 1 commit intop-ranav:masterfrom
Open
allow boolean switch with '--enable-foo=true/false'#318rtgiskard wants to merge 1 commit intop-ranav:masterfrom
rtgiskard wants to merge 1 commit intop-ranav:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a try to implement the #313, however this make
flag()applynargs(0,1), and break assumption for some of the test.For example:
program.parse_args({"./test", "--enable-foo", "dump"}), with--enable-fooset withflag(), the positional argumentdumpwill be consumed by the flag and cause trouble.And I'm not sure, this seems to be in consistent with the original design, there may be better solutions.