Bugfix - Argument::store into<bool> mishandling implicit value#416
Open
matan7890 wants to merge 2 commits intop-ranav:masterfrom
Open
Bugfix - Argument::store into<bool> mishandling implicit value#416matan7890 wants to merge 2 commits intop-ranav:masterfrom
matan7890 wants to merge 2 commits intop-ranav:masterfrom
Conversation
added 2 commits
November 28, 2025 20:37
store_into<bool> method assumes the value to store into the given variable is alawys true, regardless of the values given to m_default_value / m_implicit_value. This commit fixes issue p-ranav#413
|
亲，来信已经收到！祝你快乐！
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argument::store_into method assumes the value to store into the given
variable is alawys true, regardless of the values given to
m_default_value / m_implicit_value.
This commit fixes issue #413.
It also comes with a nice regression test :)