Added resteem functionality to Responder#18
Open
TwinkieWInkie wants to merge 2 commits into
Open
Conversation
TwinkieWInkie
changed the title
TwinkieWInkie
changed the title
Owner
|
Thank you very much. I will test it soon by the meantime can you please change your indention from tabs to 2 space which is the convention for this codebase. |
Collaborator
Author
|
Thats bonkers.
I swear it was spaces pre-commit, I guess I misconfigured VIM.
…On Mon, Apr 16, 2018, 8:12 AM p0o ***@***.***> wrote:
Thank you very much. I will test it soon by the meantime can you please
change your indention from tabs to 2 space which is the convention for this
codebase.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AVm2rQQAP1AvcP5iJ5Q9cOi9MQZQU085ks5tpDY8gaJpZM4TVkVb>
.
|
p0o
requested changes
Apr 19, 2018
p0o
left a comment
p0o
left a comment
Owner
There was a problem hiding this comment.
There are some issues with the code, I tried debugging it for a short period but even with fixing these issues the bot is not resteeming. Not sure what is the problem maybe you test yourself and check.
| const wif = this.postingKey || this.activeKey; | ||
|
|
||
| const action = JSON.stringify(['reblog'], { | ||
| account: this.responserUsername, |
| wif, | ||
| [], | ||
| [this.responderUsername], | ||
| 'follow', |
Owner
There was a problem hiding this comment.
Why the id for transaction is "follow" ? I don't remember exactly but I think it should be a random string like a uuid. since the new commit in node from the second execution it returns this error:
Unhandled rejection RPCError: Assert Exception:_callbacks.find( txid ) == _callbacks.end(): Transaction is a duplicate
at new RPCError (/Users/p0o/dev/steem-bot-tests/steem-bot/node_modules/steem/lib/api/transports/http.js:39:106)
at /Users/p0o/dev/steem-bot-tests/steem-bot/node_modules/steem/lib/api/transports/http.js:74:13
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
Owner
|
@TwinkieWInkie Hey, you still want to finish this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested as of now, not expecting any errors as the implementation is correct.
close #6