Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Mirrors the Bitcoin Core process management added previously, reusing the existing generic ProcessManager for the p2poolv2 node.
1b7d304 to
ca9f1f5
Compare
Architecture UpdateSince this PR was originally opened, the intended process-management architecture for PDM has changed following maintainer discussion. The current implementation gives PDM direct ownership of the P2Poolv2 process through start/stop/restart controls and The direction is to run P2Poolv2 as a systemd user service, with the service manager owning the process lifecycle. PDM will instead connect to an already-running node through its API and provide the relevant status and interaction functionality. This means:
This direction is being tracked in p2poolv2#289. Given this, I think it's cleaner to close this PR and implement the service-based approach separately rather than refactor the current implementation. @pool2win, please correct me if I've misunderstood the intended direction before I close it. |
|
Agreed. Closing in favour of PR 289 as mentioned in the last comment. |
Summary
Adds start/stop/restart process management for the p2poolv2 node, mirroring the Bitcoin Core process management from #.
What's included
p2poolv2_pathsetting (falls back to PATH lookup when unset, same asbitcoind_path)p2pool_process_manageronAppreusing the existing genericProcessManager, with start/stop/restart/poll/shutdown--config <p2pool_conf_path>, matching the real systemd unit'sExecStart[s] Start,[t] Stop,[r] RestartTesting