Conversation
Removing bitcoin_conf_path left several tests in settings.rs with no remaining assertions - some passed trivially with zero checks. Rebuilt using p2pool_conf_path as the differentiating field: - load_settings_returns_default_when_file_missing/for_invalid_toml: restored default-field assertions - load_settings_reads_valid_file: was writing/loading/asserting nothing; now round-trips a real p2pool_conf_path value - save_with_override_writes_to_override_dir_and_default: assert override and default copies match - load_settings_reads_from_override_dir_when_set / load_settings_falls_back_to_default_when_override_unreadable: pointer and authoritative Settings were identical, so nothing could prove which one loaded - gave each a distinct p2pool_conf_path and assert the correct one wins
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the currently unused Lightning Network and Shares Market screens from PDM.
Removed
Reason
These screens are not needed at the moment. Per maintainer feedback, they can be reintroduced later if the functionality becomes necessary.
Changes
This keeps the current UI focused on the functionality that is currently required.