Skip to content

Re-enable formatting checks in CI #674

Description

@jafingerhut

These lines in test.yml have been commented out, because they give errors that I do not know how to fix: https://github.com/p4lang/PI/blob/main/.github/workflows/test.yml#L59-L62

    - name: Check style
       run: |
        docker run -w /PI pi ./tools/check_style.sh

One way to address this would be to make modifications to the source code of PI so that those checks pass.

Another would be to modify the check_style.sh script so that it does not flag the things it does now as errors.

Also perhaps some combination of the two methods above.

Another option would be to replace check_style.sh with some other style/format-checking software. I suspect there might be different things in use on other p4lang projects.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions