Make sure files created by PTF can be read by the invoking user. - #269
Merged
Merged
Conversation
ptf needs root to open raw sockets and it is normally run with sudo. Every file it wrote was then owned by root: the log directory, log files, pcaps, xUnit results, and the profiler dump. That makes the files unreadable in normal operations. Chown those files to SUDO_UID/SUDO_GID as they are created. This only happens when running as root under sudo, and does nothing otherwise. Signed-off-by: Fabian Ruffy <212419330+fruffy-xsight@users.noreply.github.com>
Signed-off-by: Fabian Ruffy <212419330+fruffy-xsight@users.noreply.github.com>
jafingerhut
approved these changes
Jul 29, 2026
jafingerhut
left a comment
jafingerhut
left a comment
Collaborator
There was a problem hiding this comment.
This is definitely an annoyance for me, too. Thanks for the enhancement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a pet peeve of mine.
ptf needs root to open raw sockets and it is normally run with sudo. Every file it wrote was then owned by root: the log directory, log files, pcaps, xUnit results, and the profiler dump. That makes the files unreadable in normal operations.
Chown those files to SUDO_UID/SUDO_GID as they are created. This only happens when running as root under sudo, and does nothing otherwise.