Wip policy api#33
Merged
Merged
Conversation
Includes a minima implementation and unit tests.
Fully replace old policy struct with new policy API. Update SRTP core policy validation/stream init to consume the new policy layout, including MKI/key handling and null-null policy behavior. Only validate policy once where it is passed in. Remove policy lists, multiple policies now need to be add via srtp_add_stream API. Migrate tests, fuzzer, and docs to the new API and expand policy API test coverage.
Use add and remove in the same way as the keys api.
The new policy api replaces the need for public srtp_crypto_policy_t. If for some reason there is a need to explicitly set key lengths etc it can be add to the policy api later.
It is a little unclear is a key should be provided or not. Keep current behavior for now.
Add explicit policy tests for srtp_profile_null_sha1_80 and srtp_profile_null_sha1_32. The tests verify that both profiles require a 16-byte master key and 14-byte salt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.