Move copr_build_handler to short running queue#3029
Open
majamassarini wants to merge 1 commit intopackit:mainfrom
Open
Move copr_build_handler to short running queue#3029majamassarini wants to merge 1 commit intopackit:mainfrom
majamassarini wants to merge 1 commit intopackit:mainfrom
Conversation
majamassarini
requested review from
lbarcziova
and removed request for
a team
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 50s |
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
Member
|
is this waiting for something or can we merge so that we can see behaviour in staging for a few days? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at Grafana, the copr build handler tasks take less time than the copr build start/end handler tasks. The latter already are in the short running queue.
Also the highest peaks, around 12 minutes, all come from the copr build start/end handlers; the highest peak I saw for the copr build handler in the last 30 days was 4 minutes.
So I think this change is safe.
Fix #2995