Recommend system-rpm-config on Fedora/EL

[nforro]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @nforro, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a recommendation for the system-rpm-config package across various Python spec files for Fedora and Enterprise Linux distributions. This change aims to improve the reliability of spec file preprocessing and parsing by ensuring that essential SRPM macros are consistently present in the build environment, thereby preventing potential build failures related to missing macros.

Highlights

• Dependency Recommendation: Added Recommends: system-rpm-config to several Python spec files to ensure necessary SRPM macros are available for spec file processing on Fedora and Enterprise Linux systems.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• centos-integration-sig/python-specfile.spec
  • Added Recommends: system-rpm-config with a comment explaining its purpose for SRPM macros.
• epel10/python-specfile.spec
  • Added Recommends: system-rpm-config with a comment explaining its purpose for SRPM macros.
• epel8/python-specfile.spec
  • Added Recommends: system-rpm-config with a comment explaining its purpose for SRPM macros.
• fedora/python-specfile.spec
  • Added Recommends: system-rpm-config with a comment explaining its purpose for SRPM macros.

Activity

• No activity has occurred on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds system-rpm-config as a recommended dependency to the spec files for Fedora and EL distributions. This is a good change as it will improve the user experience for those parsing spec files that use distribution-specific macros. I've added a few minor comments regarding extra blank lines to keep the spec files clean and consistent.

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/e2a0fecbcb5d4805991c8ba6b20f2e1e

✔️ pre-commit SUCCESS in 2m 05s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 35s
✔️ specfile-tests-pip-deps SUCCESS in 1m 31s

[xsuchy]

+1

[majamassarini]

🙏🏻

[centosinfra-prod-github-app]

Build succeeded (gate pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/a1e94cfc339d4437957acfc6dba81e69

✔️ pre-commit SUCCESS in 2m 05s