[postponed] Record #3590050 (locale_status functions) as skip pending core re-land#366
Open
bbrala wants to merge 1 commit into
Open
[postponed] Record #3590050 (locale_status functions) as skip pending core re-land#366bbrala wants to merge 1 commit into
bbrala wants to merge 1 commit into
Conversation
Issue #3590050 (deprecate locale_status functions, replace with LocaleSource service methods) was committed to 11.x/main then reverted from 11.4.x over installer test failures; status Needs work. Not implementable yet: introducedVersion is unknown after the 11.4.x revert, and the target LocaleSource methods (saveSource/deleteSources/ clearSources/deleteSourcesByLanguage) are absent from a verifiable core checkout. Record as skip in the source-of-truth file so it drops out of the pending list until it re-lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why postponed
Core issue #3590050 "Deprecate and replace locale_status related functions" was committed to
11.x/main(Jun 9) then reverted from11.4.x(Jun 11) over installer test failures. Status is Needs work.It is not safe to implement the rector yet:
introducedVersion. It was reverted from 11.4.x, so aFunctionToServiceConfiguration('11.4.0', …)BC-wrapper would gateDeprecationHelperat a version boundary the deprecation no longer ships in. If it re-lands in 11.5+,'11.4.0'is wrong.LocaleSource::saveSource()/deleteSources()/clearSources()/deleteSourcesByLanguage()are absent from a verifiable core checkout (onlyloadSources,buildSources,sourceCheckFile,sourceBuild,buildServerPatternexist).locale_translation_status_delete_languages → deleteSourcesByLanguage(a clean 1:1 mapping) and miscategorizes it as a loop-only manual caveat.What this PR does
Records
#3590050asstatus: skipindocs/implemented-digests.yml(the source-of-truth record), so it drops out of the actionable pending list until the core change re-lands stably. Mirrors the[postponed]handling of #3530640 (PR #356).When it re-lands
Straightforward config-only
FunctionToServiceRectorbatch (FQCN, 5th argtrue) forDrupal\locale\LocaleSource— five entries, same shape as the existinglocale_translation_*rows indrupal-11.4-deprecations.php. Re-confirmintroducedVersionand method names against core first.