fix: drop message arg when converting assertResponse() to statusCodeEquals()#380
Open
bbrala wants to merge 1 commit into
Open
fix: drop message arg when converting assertResponse() to statusCodeEquals()#380bbrala wants to merge 1 commit into
bbrala wants to merge 1 commit into
Conversation
…quals() [#3332090]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Drupal 9
AssertLegacyTraitrector converts$this->assertResponse(200, 'message')to$this->assertSession()->statusCodeEquals(200, 'message'). However,WebAssert::statusCodeEquals(int $code)takes no message argument, so the surplus argument produces invalid output.The sibling rules (
assertText,assertRaw,assertNoText,assertNoRaw) already passprocessFirstArgumentOnly = trueto drop extra arguments;assertResponsewas missed.Reported in GitLab issue: https://git.drupalcode.org/project/rector/-/work_items/3332090
Fix
One-line config change in
config/drupal-9/drupal-9.1-deprecations.php(and the matching test config):The 4th parameter is
isAssertSessionMethod = true(already the default) and the 5th isprocessFirstArgumentOnly = true, which reduces the call to a single argument.Tests
$this->assertResponse(200, 'Some message.');→$this->assertSession()->statusCodeEquals(200);) to the PHPUnit fixtureassert_response.php.incand to the functionalrector_examples/rector_examples_updatedfixtures../vendor/bin/phpunit --filter AssertLegacyTraitis green (27 tests, 28 assertions).