fix: conditional (BC) removal in RemoveAliasManagerCacheMethodCallsRector

[bbrala]

Problem

RemoveAliasManagerCacheMethodCallsRector removed calls to AliasManager::setCacheKey() / writeCache() unconditionally. As reported by Berdir on #3600789, that breaks backward compatibility on Drupal < 11.3.

These methods only became no-ops at 11.3.0, when the path alias preload cache was replaced by a Fiber-based bulk-lookup strategy (CR 3496369, CR 3532412). Before 11.3.0 they performed real caching work, so deleting the call outright silently drops the alias preload caching for modules that still support < 11.3.

Fix

The rector now extends AbstractDrupalCoreRector (version-gated on 11.3.0):

• BC support enabled → the call is wrapped in a DeprecationHelper::backwardsCompatibleCall() with a no-op current callable, so the caching still runs on Drupal < 11.3 and is skipped on 11.3+:

  \Drupal\Component\Utility\DeprecationHelper::backwardsCompatibleCall(
      \Drupal::VERSION, '11.3.0',
      fn() => null,
      fn() => $aliasManager->setCacheKey('/some/path'),
  );

• BC support disabled (or minimum supported core ≥ 11.3) → the call is removed as before.

Verified against core source: backwardsCompatibleCall() takes two required callable params and invokes one based on the version compare; a fn() => null current callable is valid and its return is discarded in statement context. No deprecation notice fires because the deprecated method is only invoked on the < 11.3 branch. The shared createBcCallOnExpr() helper can't produce this shape (it needs a replacement Expr; this is a whole-statement deletion), so the wrapper node is built in the rector, keeping the Expression-level match.

Real-world validation (contrib search)

Every contrib module that actually calls these methods on an AliasManager has already added a manual BC guard — confirming unconditional removal is wrong and the conditional approach is correct:

• redirect — if ($this->aliasManager instanceof AliasManager && version_compare(\Drupal::VERSION, '11.3', '<')) (Berdir's MR !196)
• domain_path / domain_unique_path_alias — alias-manager decorators guarding the passthrough with if (method_exists($this->inner, 'setCacheKey'))
• seo_urls — calls its own SeoUrlManager (not AliasManager), so the type guard correctly skips it

Contrib writeCache() hits are almost all ModuleHandler::writeCache() and other unrelated methods, not AliasManager — correctly ignored by the type guard.

Tests

• fixture-bc/ — proves the BC wrapper output (basic + concrete receiver).
• fixture/ — proves plain removal when BC is disabled.
• fixture-below-version/ — proves the rector does not fire when target Drupal < 11.3.

Full suite green (699 tests), PHPStan clean, php-cs-fixer clean.

🤖 Generated with Claude Code