Conversation
|
Not sure if tests with hardcoded translations are still relevant or if those hardcoded values should also be edited. |
|
Yes - I think they are valuable - and sorry that I used French as the test language! Those tests make sure that we are really properly grabbing the correct file and properly configuring babel/pybabel. If you would - please change the tests to match your changes. Thanks |
5fee2d6 to
5584210
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1128 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 40 40
Lines 5008 5008
=======================================
Hits 4934 4934
Misses 74 74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
OK, PR ready. Lint test still fails due to an outdated lib, but it is out of the scope of this PR. |
| existing = ( | ||
| "Veuillez saisir votre code d'authentification généré via: authentificateur" | ||
| ) | ||
| existing = "Veuillez saisir votre code d'authentification généré avec : authentificateur" |
There was a problem hiding this comment.
Lint is failing (flake8) because 2 lines are too long.....
This translation uses a gender neutral variant for French.