Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 40 40
Lines 5026 5033 +7
=======================================
+ Hits 4952 4959 +7
Misses 74 74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As a default we use Cache-Control: private no-store private is the minimum required to ensure that no responses get cached in a shared cache. no-store goes further and requests that responses aren't cached at all - even at the browser. Note that some browsers (e.g. Chrome) have recently started, in some instances, to ignore no-store. Flask-Security endpoints send and receive very little data - so not caching them shouldn't affect performance. As enumerated in issue #1178 - there are very few current APIs that return any sensitive information as part of a GET request that if allowed to be cached in a shared cache would enable information leaking. At least one place is in the case of using Authorization-Tokens, no sessions/session cookies. A GET /login from an authenticated user could return sensitive info that could be cached. closes #1178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a default we use Cache-Control: private no-store private is the minimum required to ensure that no responses get cached in a shared cache. no-store goes further and requests that responses aren't cached at all - even at the browser. Note that some browsers (e.g. Chrome) have recently started, in some instances, to ignore no-store.
Flask-Security endpoints send and receive very little data - so not caching them shouldn't affect performance. As enumerated in issue #1178 - there are very few current APIs that return any sensitive information as part of a GET request that if allowed to be cached in a shared cache would enable information leaking. At least one place is in the case of using Authorization-Tokens, no sessions/session cookies. A GET /login from an authenticated user could return sensitive info that could be cached.
closes #1178