Skip to content

Small fixes - #4

Open
krajzeg wants to merge 2 commits into
palparepa:masterfrom
krajzeg:master
Open

Small fixes#4
krajzeg wants to merge 2 commits into
palparepa:masterfrom
krajzeg:master

Conversation

@krajzeg

@krajzeg krajzeg commented Oct 17, 2020

Copy link
Copy Markdown

Hey,

Two unrelated fixes in this PR (not the best practice, I know).

The important one is something I found while checking out the source code to learn how the game works - the "analyze level" of an ICE was not taken into account at all when determining its GetEffectiveRating(), due to a stray "this":

	if (this.bIncludeAnalyze)
		nRating -= this.m_nAnalyzed;

This makes analyze completely useless without the fix.

The other is a small fix for issue #1, enabling the scan button in COP nodes.

@TideGear

Copy link
Copy Markdown

@krajzeg
Feel free to PR this to my fork...
https://github.com/TideGear/decker/tree/master
...Are you sure these fixes are what Shawn Overcash intended?

@krajzeg

krajzeg commented Jul 30, 2025

Copy link
Copy Markdown
Author

@TideGear This has been years ago now, but I'm pretty sure the analyze bug is a bug in the port. I'm not sure how/if scanning COP nodes worked in the original.
In any case, won't be filing a PR, but feel free to use/not use these one-line changes in your fork - which is a cool idea, would be nice to be able to play Decker on a phone! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants